fix: resolve security vulnerabilities in cipher-base, sha.js, and glob#77
Merged
fix: resolve security vulnerabilities in cipher-base, sha.js, and glob#77
Conversation
- Add yarn resolutions for cipher-base (^1.0.5) to fix CVE-2025-9287 - Add yarn resolutions for sha.js (^2.4.12) to fix CVE-2025-9288 - Pin glob to 7.2.3 via yarn resolutions to prevent CVE-2025-64756 - Downgrade rimraf from 6.1.2 to 3.0.2 for compatibility with glob 7.x Closes https://github.com/getditto/react-ditto/security/dependabot/179 Closes https://github.com/getditto/react-ditto/security/dependabot/180 Closes https://github.com/getditto/react-ditto/security/dependabot/191
pvditto
force-pushed
the
pv/sec-updates
branch
from
6a627be to
5528263
Compare
teodorciuraru
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves three security vulnerabilities identified by Dependabot:
CVE-2025-9287 (Critical): cipher-base missing type checks, leading to hash rewind and passing on crafted data
CVE-2025-9288 (Critical): sha.js missing type checks leading to hash rewind and passing on crafted data
CVE-2025-64756 (High): glob CLI command injection via -c/--cmd executes matches with shell:true (affects glob >= 11.0.0, < 11.1.0)
Changes
cipher-base(^1.0.5),sha.js(^2.4.12), andglob(^7.2.3)rimrafdevDependency from 6.1.2 → 3.0.2 to maintain compatibility with glob 7.xTest Plan
yarn installcompletes successfullyyarn build- build completed successfullyyarn test- all 49 tests passedyarn docs:generate- documentation generated successfullyyarn why cipher-baseshows version 1.0.7yarn why sha.jsshows version 2.4.12yarn why globshows version 7.2.3 (safe from CVE-2025-64756)